first round of updates to disable type assertions #2879

rsun19 · 2024-06-05T15:21:11Z

Description

We would like to limit the use of type assertions as much as possible. However, a large amount of these assertions are made in a type-cast like way making it very tricky to type check them. We may need to resort to using as in the type guard in those cases.

How Has This Been Tested?

npm run test

Request review criteria:

Self checklist (all need to be checked):

The developer has manually tested the changes and verified that the changes work
Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).

After the PR is posted & before it merges:

The developer has tested their solution on a cluster by using the image produced by the PR to main

frontend/src/__tests__/unit/testUtils/hooks.ts

frontend/src/utilities/useAcceleratorProfileState.ts

...pages/projects/screens/detail/overview/serverModels/deployedModels/DeployedModelsSection.tsx

frontend/src/pages/modelServing/screens/metrics/utils.tsx

frontend/src/pages/modelServing/screens/global/utils.ts

.../src/pages/modelRegistry/screens/RegisteredModelsArchive/RegisteredModelsArchiveListView.tsx

frontend/src/concepts/pipelines/content/tables/usePipelineFilter.ts

frontend/src/concepts/pipelines/content/compareRuns/metricsSection/roc/utils.ts

frontend/src/concepts/metrics/utils.ts

frontend/src/components/DocCardBadges.tsx

frontend/src/components/OdhDocListItem.tsx

frontend/src/concepts/areas/utils.ts

frontend/src/concepts/dashboard/DashboardSearchField.tsx

frontend/src/pages/modelServing/screens/metrics/performance/ModelMeshMetrics.tsx

frontend/src/pages/modelServing/screens/metrics/performance/ServerGraphs.tsx

frontend/src/pages/projects/screens/spawner/environmentVariables/EnvTypeSelectField.tsx

frontend/src/utilities/NavData.tsx

frontend/src/utilities/useDraggableTable.ts

codecov · 2024-06-13T19:05:33Z

Codecov Report

Attention: Patch coverage is 71.50538% with 53 lines in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (3d62686) to head (666ccb4).

❗ Current head 666ccb4 differs from pull request most recent head 0af9464

Please upload reports for the commit 0af9464 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2879      +/-   ##
==========================================
- Coverage   78.54%   78.45%   -0.10%     
==========================================
  Files        1138     1139       +1     
  Lines       24146    24224      +78     
  Branches     6098     6151      +53     
==========================================
+ Hits        18966    19005      +39     
- Misses       5180     5219      +39

Files	Coverage Δ
frontend/src/api/errorUtils.ts	`100.00% <100.00%> (ø)`
frontend/src/api/modelRegistry/errorUtils.ts	`100.00% <100.00%> (ø)`
frontend/src/api/pipelines/errorUtils.ts	`100.00% <100.00%> (ø)`
frontend/src/api/prometheus/serving.ts	`95.91% <100.00%> (+0.79%)`	⬆️
frontend/src/api/trustyai/errorUtils.ts	`85.71% <100.00%> (-1.79%)`	⬇️
frontend/src/app/AppContext.ts	`100.00% <100.00%> (ø)`
frontend/src/components/DocCardBadges.tsx	`95.23% <100.00%> (ø)`
...end/src/components/FilterSidePanelCategoryItem.tsx	`100.00% <100.00%> (ø)`
frontend/src/components/OdhDocListItem.tsx	`75.60% <100.00%> (ø)`
frontend/src/components/ToastNotification.tsx	`65.00% <100.00%> (+1.84%)`	⬆️
... and 77 more

... and 21 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d62686...0af9464. Read the comment docs.

frontend/src/utilities/useAcceleratorProfileState.ts

frontend/src/pages/modelServing/screens/global/utils.ts

frontend/src/api/prometheus/serving.ts

frontend/src/concepts/modelRegistry/context/ModelRegistryContext.tsx

...tend/src/concepts/pipelines/content/compareRuns/metricsSection/PipelineRunArtifactSelect.tsx

...nd/src/concepts/pipelines/content/configurePipelinesServer/ConfigurePipelinesServerModal.tsx

frontend/src/concepts/pipelines/content/createRun/RunPage.tsx

frontend/src/pages/learningCenter/DocTypeFilters.tsx

frontend/src/pages/modelRegistry/screens/ModelVersionsArchive/ModelVersionsArchiveListView.tsx

frontend/src/pages/modelServing/screens/global/utils.ts

frontend/src/typeHelpers.ts

frontend/src/concepts/projects/ProjectsContext.tsx

frontend/src/pages/learningCenter/DocTypeFilters.tsx

...erving/screens/metrics/bias/BiasConfigurationPage/BiasConfigurationModal/MetricTypeField.tsx

christianvogt · 2024-06-21T15:11:32Z

/lgtm
/approve

openshift-ci · 2024-06-21T15:11:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from Gkrumbach07 and mturley June 5, 2024 15:21

rsun19 changed the title ~~first round of updates to disable type assertions~~ [WIP] first round of updates to disable type assertions Jun 5, 2024

openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jun 5, 2024

christianvogt reviewed Jun 5, 2024

View reviewed changes

rsun19 force-pushed the eslint-disable-assertion branch 2 times, most recently from 4ac45ef to 8011609 Compare June 6, 2024 20:51

christianvogt reviewed Jun 6, 2024

View reviewed changes

rsun19 force-pushed the eslint-disable-assertion branch from 8011609 to 1b5430c Compare June 7, 2024 19:47

openshift-merge-robot added the needs-rebase PR needs to be rebased label Jun 8, 2024

rsun19 force-pushed the eslint-disable-assertion branch 2 times, most recently from 2b1b073 to 1112c0d Compare June 10, 2024 15:43

openshift-merge-robot removed the needs-rebase PR needs to be rebased label Jun 10, 2024

rsun19 force-pushed the eslint-disable-assertion branch 3 times, most recently from d4b787e to cc0d111 Compare June 10, 2024 17:34

rsun19 changed the title ~~[WIP] first round of updates to disable type assertions~~ first round of updates to disable type assertions Jun 10, 2024

openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jun 10, 2024

christianvogt reviewed Jun 11, 2024

View reviewed changes

rsun19 force-pushed the eslint-disable-assertion branch 3 times, most recently from e977cc1 to af884c1 Compare June 13, 2024 17:51

openshift-merge-robot added the needs-rebase PR needs to be rebased label Jun 13, 2024

rsun19 force-pushed the eslint-disable-assertion branch 2 times, most recently from 933956e to 0722fd0 Compare June 13, 2024 18:21

openshift-merge-robot removed the needs-rebase PR needs to be rebased label Jun 13, 2024

rsun19 force-pushed the eslint-disable-assertion branch from c9cd7ed to e3f487a Compare June 13, 2024 18:31

rsun19 force-pushed the eslint-disable-assertion branch from e3f487a to 4c353b9 Compare June 13, 2024 20:09

rsun19 commented Jun 13, 2024

View reviewed changes

frontend/src/utilities/useAcceleratorProfileState.ts Outdated Show resolved Hide resolved

rsun19 force-pushed the eslint-disable-assertion branch 2 times, most recently from 10f43ce to 3103b0e Compare June 14, 2024 17:35

openshift-merge-robot added the needs-rebase PR needs to be rebased label Jun 14, 2024

rsun19 force-pushed the eslint-disable-assertion branch from 3103b0e to 70fae10 Compare June 14, 2024 17:39

openshift-merge-robot removed the needs-rebase PR needs to be rebased label Jun 14, 2024

rsun19 force-pushed the eslint-disable-assertion branch from 70fae10 to 4a3e920 Compare June 14, 2024 18:12

rsun19 commented Jun 14, 2024

View reviewed changes

frontend/src/pages/modelServing/screens/global/utils.ts Outdated Show resolved Hide resolved

rsun19 force-pushed the eslint-disable-assertion branch from 4a3e920 to 538ba4d Compare June 14, 2024 19:40

christianvogt reviewed Jun 17, 2024

View reviewed changes

rsun19 force-pushed the eslint-disable-assertion branch 2 times, most recently from 5d5b8c7 to cb9ac68 Compare June 18, 2024 17:51

christianvogt reviewed Jun 18, 2024

View reviewed changes

frontend/src/concepts/projects/ProjectsContext.tsx Outdated Show resolved Hide resolved

frontend/src/pages/learningCenter/DocTypeFilters.tsx Outdated Show resolved Hide resolved

rsun19 force-pushed the eslint-disable-assertion branch 3 times, most recently from 666ccb4 to 9658cae Compare June 21, 2024 14:15

christianvogt reviewed Jun 21, 2024

View reviewed changes

...erving/screens/metrics/bias/BiasConfigurationPage/BiasConfigurationModal/MetricTypeField.tsx Outdated Show resolved Hide resolved

rsun19 force-pushed the eslint-disable-assertion branch from 9658cae to bff3169 Compare June 21, 2024 14:30

first round of updates to disable type assertions

0af9464

rsun19 force-pushed the eslint-disable-assertion branch from bff3169 to 0af9464 Compare June 21, 2024 14:36

openshift-ci bot assigned christianvogt Jun 21, 2024

openshift-ci bot added the lgtm label Jun 21, 2024

openshift-ci bot added the approved label Jun 21, 2024

openshift-merge-bot bot merged commit 8808e8d into opendatahub-io:main Jun 21, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

first round of updates to disable type assertions #2879

first round of updates to disable type assertions #2879

rsun19 commented Jun 5, 2024 •

edited

Loading

codecov bot commented Jun 13, 2024 •

edited

Loading

christianvogt commented Jun 21, 2024

openshift-ci bot commented Jun 21, 2024

first round of updates to disable type assertions #2879

first round of updates to disable type assertions #2879

Conversation

rsun19 commented Jun 5, 2024 • edited Loading

Description

How Has This Been Tested?

Request review criteria:

codecov bot commented Jun 13, 2024 • edited Loading

Codecov Report

christianvogt commented Jun 21, 2024

openshift-ci bot commented Jun 21, 2024

rsun19 commented Jun 5, 2024 •

edited

Loading

codecov bot commented Jun 13, 2024 •

edited

Loading